Added checking in Error function in Parser #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'd love to see a test! I know that we don't have that many tests for the parser, but it seems that people are using Rhino to parse and help interpret JavaScript in lots of different projects and improving the parsers's quality via better code coverage would be a big help. |
szegedi
suggested changes
May 19, 2018
| @@ -438,7 +438,6 @@ private static int YearFromTime(double t) | |||
|
|
|||
| double y = Math.floor(t / (msPerDay * 365.2425)) + 1970; | |||
| double t2 = TimeFromYear(y); | |||
|
|
|||
There was a problem hiding this comment.
This is irrelevant and should be removed.
| @@ -233,8 +233,12 @@ void addError(String messageId, int position, int length) { | |||
| } | |||
|
|
|||
| void addError(String messageId, String messageArg) { | |||
| addError(messageId, messageArg, ts.tokenBeg, | |||
| ts.tokenEnd - ts.tokenBeg); | |||
| int beg = -1, end = -1; | |||
There was a problem hiding this comment.
I'd really like us to adopt a single-assignment style for local variables in Rhino whenever possible, so
final int beg, end;
if (ts != null) {
...
} else {
beg = end = -1;
}would be much preferred.
|
The issue this PR fixes is already covered by #987, so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases of TokenStream not being defined. Like in issue#386 #386