Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

updated Electron to 4.0.5 #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyril23
Copy link

@cyril23 cyril23 commented Mar 21, 2019

I have bumped Electron to 4.0.5, because I was getting error signal 11 SEGV_MAPERR with the old version which will not be fixed due to old Electron version: electron/electron#9236

It runs fine so far, since 4 weeks and about 200 PDFs / day.

edit: I use HTML to PDF only (no PNG or whatever)

@msokk
Copy link
Owner

msokk commented Mar 23, 2019

Master is on 4.0.6, but I haven't had time to release it as v4 renders blank PDF-s on higher loads. Maybe it is an issue with test setup.

@cyril23
Copy link
Author

cyril23 commented Apr 10, 2019

Master is on 4.0.6, but I haven't had time to release it as v4 renders blank PDF-s on higher loads. Maybe it is an issue with test setup.

How to check if PDFs with blank pages have been created?

  • Does it still return 200 OK?
  • What's the size of those PDFs? I would like to check my PDF exports.

edit: have you opened up an issue for this?

@msokk
Copy link
Owner

msokk commented Apr 10, 2019

@cyril23 The tests fail, I haven't created an issue, it returns 695 bytes big valid blank PDF file, you can check it like this - https://github.com/msokk/electron-render-service/blob/master/__tests__/stability.js#L30, have to slice the beginning bytes out as that bit contains a timestamp.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants