Display the absolute address for relative branches for ARM32 and ARM64#746
Open
canova wants to merge 2 commits intomstange:mainfrom
Open
Display the absolute address for relative branches for ARM32 and ARM64#746canova wants to merge 2 commits intomstange:mainfrom
canova wants to merge 2 commits intomstange:mainfrom
Conversation
This will allow us to see the changes in the following commit.
Both of them had some quirks that we had to overcome differently. On ARM64, some opcodes can take multiple operands, and the pc offset operand could be in different positions. On ARM32, branch offsets are shifted by either 1 or 2. But the immediate value that is stored inside the yaxpeax_arm Operand enum is a non-shifted value. So we have to shift them ourselves.
canova
force-pushed
the
asm-absolute-branches
branch
from
70495c9 to
f281ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the ARM32 and ARM64 decoding to display the absolute addresses instead of relative ones.
It also adds a fixture for ARM64 and adds an asm endpoint test with it. Apparently we have tests for both ARM32 and x86_64 but we didn't have one for ARM64.