transaction: Ignore unused variable warnings #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may get some warnings when generating code as: warning: unused variable ‘_cgo_a’ This is something due to the fact we use `-Wall` that is not something golang upstream suggests. However, since this is the only warning we may have and it's not a super relevant one, we can ensure we ignore it.
3v1n0
force-pushed
the
prevent-unused-var
branch
from
ef2e8b7 to
d11b37f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 2 2
Lines 147 147
=======================================
Hits 121 121
Misses 23 23
Partials 3 3 ☔ View full report in Codecov by Sentry. |
didrocks
added a commit
to ubuntu/authd
that referenced
this pull request
Jan 19, 2024
Bump go-pam requirement so that we do ignore unused-variables warning on cgo generated code. It basically includes msteinert/pam#22 Closes: #179 UDENG-2104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may get some warnings when generating code as:
warning: unused variable ‘_cgo_a’
This is something due to the fact we use
-Wallthat is not something golang upstream suggests.However, since this is the only warning we may have and it's not a super relevant one, we can ensure we ignore it.