Initial #1
Initial #1
Conversation
Here we are re-using the reCAPTCHA v2 site key setting so we don't need to superfluously remove a setting and add a new one.
| * @since 1.0.0 | ||
| */ | ||
| function template_base_paths( array $paths ): array { | ||
| $slug = "tec-labs-" . PUE::get_slug(); |
There was a problem hiding this comment.
I'd try to centralize a place for the slug, for maintenance and clarity purposes. We currently have it in the Plugin and PUE classes (for the latter, with the extension- prefix). I think for the template path it would be more friendly to use the plugin slug, but that's a personal preference. PUE is oriented to the update engine.
There was a problem hiding this comment.
@bordoni just FYI. What do you think about this? In general, for the extensions?
| @@ -0,0 +1,113 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Do we have a way only to inject the pieces that we need for the reCaptcha?
If we make changes to CE forms and this extension is enabled, then this template will be out of date and maybe buggy (assuming that it will take time to update the extension if we make changes in the plugin). This could be a problem for support.
There was a problem hiding this comment.
@juanfra I couldn't find a way to inject things that would be needed. However, it could be done if we made some slight modifications to the original template files.
As far as I remember:
- The
<form>needs an id. - The submit button needs an extra class. We could introduce a filter to be able to add that.
- The submit button needs four parameters, which could be done with another filter.
- We need to find a way to disable the
captcha.phpfile (which is for v2) in case we're using v3. Again, a filter can do the trick.
I know that's a lot of filters. :) That would be a fast way to have a simpler extension without template overrides.
In general it would be best to do all this in core - I'm sure you agree - so we wouldn't need an extension. I'd be happy to work on it as time allows.
| @@ -0,0 +1,64 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Same question about only injecting the reCaptcha pieces rather than overriding the entire template.
Co-authored-by: Juan Aldasoro <juanfra@theeventscalendar.com>
Co-authored-by: Juan Aldasoro <juanfra@theeventscalendar.com>
Co-authored-by: Juan Aldasoro <juanfra@theeventscalendar.com>
The extension adds reCAPTCHA v3 support for Community Events with the help of some template overrides.
Docs: https://developers.google.com/recaptcha/docs/v3