Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial #1
base: main
Are you sure you want to change the base?
Initial #1
Changes from 17 commits
d62b37d
9e82a54
4594ddb
ea6eac4
8fc7bd6
23e664e
c28cd2d
49108b2
fc86e9b
dd51c94
fbbaddc
4861f47
6c6d2c7
b717953
7793951
5ce18de
33c38bb
927e81d
df0743a
e9398b1
743dbcf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd try to centralize a place for the slug, for maintenance and clarity purposes. We currently have it in the Plugin and PUE classes (for the latter, with the
extension-
prefix). I think for the template path it would be more friendly to use the plugin slug, but that's a personal preference. PUE is oriented to the update engine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bordoni just FYI. What do you think about this? In general, for the extensions?