Add in app banner message for a new device

[Rawa]

• Rework how notifications work and introduce a InAppNotificationController
• Add New Device notification for when the user logs in, informing the user about the newly added device.

---

This change is 

[linear]

DROID-92 Add in-app banner message for a new device

Add an in-app banner message that the user need to close for it to disappear, when the user has closed the in-app banner message the device name and time left are shown in the header (see referenced card), Confluence and Zeplin links in Parent card

[Pururun]

Reviewed 5 of 68 files at r1, 76 of 76 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/notificationbanner/NotificationBanner.kt line 90 at r3 (raw file):

) {
    val previous = rememberPrevious(current = notification, shouldUpdate = { _, _ -> true })
    // Fix for animating t hide

Nit: to hide

---

android/lib/resource/src/main/res/values/strings.xml line 161 at r3 (raw file):

    <string name="vpn_permission_error_notification_title">VPN permission error</string>
    <string name="vpn_permission_error_notification_message">Always-on VPN might be enabled for another app</string>
    <string name="new_device_notification_title">NEW DEVICE CREATED</string>

I'm not sure about this, do we want to set all caps in the code or have all caps in the strings?

[Pururun]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/usecase/AccountExpiryNotificationUseCase.kt line 31 at r3 (raw file):

    private fun AccountExpiry.isCloseToExpiring(): Boolean {
        val threeDaysFromNow = DateTime.now().plusDays(3)

This magic number should be a constant.

[Rawa]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad and @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/notificationbanner/NotificationBanner.kt line 90 at r3 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Nit: to hide

Done

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/usecase/AccountExpiryNotificationUseCase.kt line 31 at r3 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This magic number should be a constant.

Yeah, I agree, this was from the previous implementation, I've moved it into constants now

---

android/lib/resource/src/main/res/values/strings.xml line 161 at r3 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I'm not sure about this, do we want to set all caps in the code or have all caps in the strings?

Not sure, but it was all caps in messages.po, I'm unsure if that is case sensitive? Maybe @albin-mullvad has an opinion?

[Pururun]

Reviewed 13 of 13 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad and @Rawa)

---

-- commits line 9 at r4:
Should probably be merged into "Rework notifications"

Also should also update the change log.

---

android/lib/resource/src/main/res/values/strings.xml line 161 at r3 (raw file):

Previously, Rawa (David Göransson) wrote…

Not sure, but it was all caps in messages.po, I'm unsure if that is case sensitive? Maybe @albin-mullvad has an opinion?

If it is the text we get from messages.po I think we should keep it.

[Rawa]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

-- commits line 9 at r4:

Previously, Pururun (Jonatan Rhodin) wrote…

Should probably be merged into "Rework notifications"

Also should also update the change log.

Added them to the respective commits now 👍

[Rawa]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

-- commits line 9 at r4:

Previously, Rawa (David Göransson) wrote…

Added them to the respective commits now 👍

Done.

[Pururun]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[albin-mullvad]

Reviewable status: complete! all files reviewed, all discussions resolved

---

android/lib/resource/src/main/res/values/strings.xml line 161 at r3 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

If it is the text we get from messages.po I think we should keep it.

I think we should avoid all caps in our strings (and template) since no other notification titles are in all-caps in our strings (template). Would be nice to change/align this with desktop.

[Rawa]

Reviewable status: complete! all files reviewed, all discussions resolved

---

android/lib/resource/src/main/res/values/strings.xml line 161 at r3 (raw file):

Previously, albin-mullvad wrote…

I think we should avoid all caps in our strings (and template) since no other notification titles are in all-caps in our strings (template). Would be nice to change/align this with desktop.

Actually some of the notification titles are all caps:
UPDATE AVAILABLE
UNSUPPORTED VERSION

but yes some are not:
Account credit expires soon
Blocking internet

Spoke with Desktop, they make all the titles all caps in translation for title but also capitalize all the strings. They also mentioned that if there is a quirk for some languages it makes sense to capitalize them in strings only (but this isn't they case right now).

For our consistency I think it would be nice to have a new task refactor the notification names so they all end with _notification_title ( like desktop has msgctxt of in-app-notifications) and are written in all caps.

[albin-mullvad]

Reviewable status: complete! all files reviewed, all discussions resolved

[Pururun]

Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved