Fix VPN settings not being persisted #6772
Conversation
There was a problem hiding this comment.
I fail to see how the changes in code affect the behavior, so I will hold off from approving this.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
There was a problem hiding this comment.
The settings for quantum and obfuscation are assigned to a var before the viewmodel is updated. Those old values are then passed to the delegate rather then the actual updated settings.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
force-pushed
the
fix-vpn-settings-not-being-persisted-ios-823
branch
from
16902ea
to
90135e4
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @buggmagnet)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
pinkisemils
deleted the
fix-vpn-settings-not-being-persisted-ios-823
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
This change is