Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VPN settings not being persisted #6772

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix VPN settings not being persisted #6772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<
private let vpnSettingsCellFactory: VPNSettingsCellFactory
private weak var tableView: UITableView?

private var obfuscationSettings: WireGuardObfuscationSettings {
WireGuardObfuscationSettings(
state: viewModel.obfuscationState,
port: viewModel.obfuscationPort
)
}

weak var delegate: VPNSettingsDataSourceDelegate?

var selectedIndexPaths: [IndexPath] {
Expand Down Expand Up @@ -261,12 +268,6 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<

deselectAllRowsInSectionExceptRowAt(indexPath)

let obfuscationSettingsUpdate = TunnelSettingsUpdate.obfuscation(WireGuardObfuscationSettings(
state: viewModel.obfuscationState,
port: viewModel.obfuscationPort
))
let quantumResistanceUpdate = TunnelSettingsUpdate.quantumResistance(viewModel.quantumResistance)

switch item {
case .dnsSettings:
tableView.deselectRow(at: indexPath, animated: false)
Expand All @@ -291,25 +292,25 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<

case .wireGuardObfuscationAutomatic:
selectObfuscationState(.automatic)
delegate?.didUpdateTunnelSettings(obfuscationSettingsUpdate)
delegate?.didUpdateTunnelSettings(TunnelSettingsUpdate.obfuscation(obfuscationSettings))
case .wireGuardObfuscationOn:
selectObfuscationState(.on)
delegate?.didUpdateTunnelSettings(obfuscationSettingsUpdate)
delegate?.didUpdateTunnelSettings(TunnelSettingsUpdate.obfuscation(obfuscationSettings))
case .wireGuardObfuscationOff:
selectObfuscationState(.off)
delegate?.didUpdateTunnelSettings(obfuscationSettingsUpdate)
delegate?.didUpdateTunnelSettings(TunnelSettingsUpdate.obfuscation(obfuscationSettings))
case let .wireGuardObfuscationPort(port):
selectObfuscationPort(port)
delegate?.didUpdateTunnelSettings(obfuscationSettingsUpdate)
delegate?.didUpdateTunnelSettings(TunnelSettingsUpdate.obfuscation(obfuscationSettings))
case .quantumResistanceAutomatic:
selectQuantumResistance(.automatic)
delegate?.didUpdateTunnelSettings(quantumResistanceUpdate)
delegate?.didUpdateTunnelSettings(TunnelSettingsUpdate.quantumResistance(viewModel.quantumResistance))
case .quantumResistanceOn:
selectQuantumResistance(.on)
delegate?.didUpdateTunnelSettings(quantumResistanceUpdate)
delegate?.didUpdateTunnelSettings(TunnelSettingsUpdate.quantumResistance(viewModel.quantumResistance))
case .quantumResistanceOff:
selectQuantumResistance(.off)
delegate?.didUpdateTunnelSettings(quantumResistanceUpdate)
delegate?.didUpdateTunnelSettings(TunnelSettingsUpdate.quantumResistance(viewModel.quantumResistance))
default:
break
}
Expand Down
Loading