Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom dns strings #6983

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 15, 2024


This change is Reviewable

Copy link

linear bot commented Oct 15, 2024

@Rawa Rawa self-assigned this Oct 15, 2024
@Rawa Rawa added the Android Issues related to Android label Oct 15, 2024
@Rawa Rawa force-pushed the update-custom-dns-warning-regarding-lan-sharing-text-droid-1346 branch from 5fd4cee to ab5e66e Compare October 15, 2024 08:58
@Rawa Rawa marked this pull request as ready for review October 15, 2024 08:58
@Rawa Rawa requested review from Pururun, albin-mullvad and kl and removed request for Pururun October 15, 2024 12:59
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/textfield/DnsTextField.kt line 43 at r2 (raw file):

@Composable
private fun ErrorSupportingText(text: String) {

If we make the icon optional we can use this for more dialogs such as create custom list

@Rawa Rawa force-pushed the update-custom-dns-warning-regarding-lan-sharing-text-droid-1346 branch from 2e64c30 to 3909b69 Compare October 18, 2024 07:01
@Rawa Rawa requested a review from Pururun October 18, 2024 07:18
Pururun
Pururun previously approved these changes Oct 18, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the update-custom-dns-warning-regarding-lan-sharing-text-droid-1346 branch from 3909b69 to 81e427a Compare October 18, 2024 08:47
@Rawa Rawa requested a review from Pururun October 18, 2024 08:48
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa merged commit 5d881c8 into main Oct 18, 2024
31 checks passed
@Rawa Rawa deleted the update-custom-dns-warning-regarding-lan-sharing-text-droid-1346 branch October 18, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants