Conversation
| #pragma warning( disable : 4800) | ||
| #endif // _WINDOWS | ||
|
|
||
| #ifndef LIB_VERSION_MAJOR |
There was a problem hiding this comment.
Are you sure about it? From my point of view, this version should be defined in library source code and not over build system. We sharing source code and for example at MA we use our own scripts for building library.
In the end of the day source code of library should define a version and not a build system, otherwise you can have different implementation with same version,
There was a problem hiding this comment.
Hi @AndriiVoitenko,
I think you are right also, but I think building the lib using the Github action is much more easier and cleaner. Something that we can to is to add a documentation how to build the lib easy manual. This is something that we can discuss more.
There was a problem hiding this comment.
Hi @adragnevVW,
you understand, that currently you defined same information in 3 different places. With this changes, if you need to change version, you need to change 3 yaml files. And semantic version rules are applied to the source code and are independent from build system.
You are right, building library with a yml file is pretty simple, if you build only library, but if you need to integrate it into a product and build this library over the product tool chain, then it will be not so easy.
By the way, check your ubuntu yml file:
and xerces is not needed at least for linux implementation.
3 participants
Implementing #110