test(iroh-relay, netcheck): move tests to use local relays#2935
Merged
dignifiedquire merged 20 commits inton0-computer:mainfrom Nov 18, 2024
Merged
Conversation
divagant-martian
changed the title
Arqu
approved these changes
Nov 18, 2024
Collaborator
Arqu
left a comment
Arqu
left a comment
There was a problem hiding this comment.
👍 from my PoV a great change, less flakey and faster tests!
dignifiedquire
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
netcheck's dependency on staging relays, using locally served ones instead. This is necessary to move netcheck out without needing to find an appropriate place for the staging values to prevent circular dependeciesBreaking Changes
RelayMapnow can be created with an iterator ofArcs directly.Notes & open questions
iroh-relay/src/server/testing.rswas added by mistake in the split pr, so the deletions are not really picked by rust and all new code should be considered.. well, new.Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.