-
Notifications
You must be signed in to change notification settings - Fork 50
Reorg of the Usage section of the docs #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e4c5b99 to
1174f15
Compare
|
This is really great! 😍 One thing that stand out to me: |
|
Love this work @melissawm! Much better than main :) Some thoughts:
|
|
as mentioned in docs meeting, I love this reorg ❤️ I dropped by because I noticed in the napari help menu we link to some of these guides, and I wanted to flag it in case we need to update any of those URLs. I don't think we do? Because it looks like it links to the file and we don't move the file. But just wanted to flag it and ask. |
Exactly! I can remove this from the ToC for now but we do think this is important, and was something users brought up during the hackathon. @DragaDoncila I will verify the help menu - good callout, I think we should be fine but we should check anyways. Worst case scenario we can also include redirects. EDIT: Only the Getting Started link needs to change to "https://napari.org/{VERSION}/getting_started/start_index.html", here's the PR: napari/napari#8455 |
|
@melissawm Looks great. Not sure if in or out of scope, but I think we can shorten a few headings:
|
|
@willingc Thanks Carol! For tutorials and workshops I'm 💯 , for "Using layers" that's what we had before, and @TimMonko brought up something he saw on a talk which we agreed on, which is having the subject (layers in this case) be upfront in these titles so readers can skim better (Tim would you mind dropping a link here?) However I'm not opposed to finding a shorter title if you have ideas! Maybe just "Layers guide"? |
|
Layers Guide would be great. Thanks @melissawm and @TimMonko |
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @melissawm
|
@melissawm Maybe change the card to match Layers guide too. Same with Quickstart and Workshops.
|
Czaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this changes
8d57535 to
139a628
Compare
|
Updated! |
|
Hi @melissawm. This looks great! BTW I created the docs locally using the pixi instructions and it worked really easily even though I'm not really a pixi user. I tried to go through the docs systematically and here are a few things I noticed:
|
|
All great points!
You can get started already if you want 😉 |
|
Thank you so much @guiwitz ! Excellent points - I will try to address them in my next commit 😄 |
|
bump |
9aba60b to
6e2ca27
Compare
|
Hello, folks! I tried addressing all the comments above. It may not be perfect but I'd like to merge this for 0.7.0 and we can continue improving in the meantime. I don't know how to solve the codespell errors though - the release notes seem to have some kind of formatting error at the source? Anyway, @guiwitz if you can take a look soon that would be awesome. There is certainly room for improvements in all of these changes but at least we have a starting point. Thanks! |
| (napari-quick-start)= | ||
|
|
||
| # Quick start | ||
| # Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My dictionary and my wife suggest this should be reverted to two words. cc: @napari/copy
| # Quickstart | |
| # Quick start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psobolewskiPhD Both versions are now acceptable. Quickstart has become the norm for technical guides, while quick start means beginning quickly. I'm fine with either though would lean toward one word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I've been corrected in other projects where people made me go with the one-word version. I'd prefer keeping it !
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
|
I think I got it all. Still trying to figure out what to do with the release notes that are causing the codespell error, but the cards and tabs are now working. Thanks! |
|
@melissawm I'm not sure what's up with the Codespell fail because it should be skipped Line 3 in ab4b01d
and in the release index PR thats what I said it was for in the commit: Should it be |
|
Ohh I see. let me investigate |
|
Wooo you were right @TimMonko , thanks!! 🙏🏻 |
|
Maybe we just got really lucky for a few months that there wasn't a misspelled truncation in that file? LOL |
TimMonko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think the remaining issues have been fixed!
psobolewskiPhD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go!
|
Gentle ping! This may help @guiwitz continue with the Open Images page 😄 |
|
You can just merge next time @melissawm . There's two approvals already 🫣 |
|
I hate self merging!! But it's noted 😁 |
# References and relevant issues Depends on napari/docs#881 # Description Updates link to Getting Started guide in Help menu. The other links in the Help menu did not change in that PR. --------- Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
# References and relevant issues Follow-up to #881 # Description While reading through the new quickstart, I noticed this mention of an un-maintained plugin. For a while, the plugin did not work, but I do think it does appear to be fixed now MouseLand/cellpose-napari#51 (comment) I propose we remove this very small mention. We can consider adding back plugins once we have our review system in place. My preference would be for us to make a "starter plugins" guide, rather than a short quip (that's hard to notice because of its placement!) in this quick start. There already is good detail here pointing people towards the hub :)


References and relevant issues
N/A
Description
At the napari hackathon @ gloBIAS, we had the chance to discuss the docs organization with a few users and came up with ideas for potential improvements to our Usage section. We also discussed some changes to our API docs, but those will be handled separately.
This is a first very rough draft that is clearly incomplete, but I wanted to stash it somewhere so the work can continue.EDIT: This is now ready for review. It only touches the first sections of the user guide but I think this is reasonable for now. This was discussed at the docs meeting this week (nov 20/21).