Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dayjs default export #479

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Fix/dayjs default export #479

merged 4 commits into from
Jul 1, 2024

Conversation

jamesray
Copy link
Member

changes import dayjs from 'dayjs' to import * as dayjs from 'dayjs' to fix

DAYJS@1.11.11/NODE_MODULES/DAYJS/PLUGIN/ADVANCEDFORMAT.JS?V=8016E08E' DOES NOT PROVIDE AN EXPORT NAMED 'DEFAULT'

import * as dayjs from 'dayjs'
import * as dayjs from 'dayjs'
@github-actions github-actions bot added the bug Something isn't working label Jun 29, 2024
bump version
@jamesray jamesray merged commit 6490903 into main Jul 1, 2024
1 check passed
@jamesray jamesray deleted the fix/dayjs-default-export branch July 1, 2024 06:43
@stephiescastle
Copy link
Member

@jamesray Noticed that we're now getting these errors when building the vue package and the vue storybook:

src/components/CalendarButton/CalendarButton.vue?vue&type=script&lang.ts (45:31): Cannot call a namespace ("dayjs").
src/components/CalendarButton/CalendarButton.vue?vue&type=script&lang.ts (46:29): Cannot call a namespace ("dayjs").
src/components/MissionDetailStats/DistanceStats.vue?vue&type=script&lang.ts (69:21): Cannot call a namespace ("dayjs").
src/components/MissionDetailStats/DistanceStats.vue?vue&type=script&lang.ts (69:30): Cannot call a namespace ("dayjs").
src/components/SearchResultsList/SearchResultsList.vue?vue&type=script&lang.ts (48:15): Cannot call a namespace ("dayjs").

Were the changes in this PR fixing anything? Or were they made as a precaution? If just a precaution, then I would recommend we change it back.

stephiescastle added a commit that referenced this pull request Jul 11, 2024
@stephiescastle stephiescastle mentioned this pull request Jul 11, 2024
17 tasks
stephiescastle added a commit that referenced this pull request Jul 11, 2024
fixes dayjs imports in external applications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants