Merge pull request #2242 from herwinw/marshal_dump_anonymous_module

natalie-lang · Sep 29, 2024 · ed151a7 · ed151a7
2 parents a12e271 + b475010
commit ed151a7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/spec/core/marshal/dump_spec.rb b/spec/core/marshal/dump_spec.rb
@@ -254,9 +254,7 @@ def _dump(level)
     end
 
     it "raises TypeError with an anonymous Module" do
-      NATFIXME 'raises TypeError with an anonymous Module', exception: SpecFailedException do
-        -> { Marshal.dump(Module.new) }.should raise_error(TypeError, /can't dump anonymous module/)
-      end
+      -> { Marshal.dump(Module.new) }.should raise_error(TypeError, /can't dump anonymous module/)
     end
   end
 

diff --git a/src/marshal.rb b/src/marshal.rb
@@ -225,6 +225,7 @@ def write_class(value)
     end
 
     def write_module(value)
+      raise TypeError, "can't dump anonymous module #{value}" if value.name.nil?
       write_char('m')
       write_string_bytes(value.name)
     end