Remove unneeded duplicate words #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herwinw
reviewed
Jul 5, 2024
| * with m <= n has has no effect, but a call with m > n is honored. | ||
| * with m <= n has no effect, but a call with m > n is honored. |
There was a problem hiding this comment.
I would prefer to not alter this file. We simply use an import of https://www.netlib.org/fp/, so we are not the source for this. Adding changes only add confusion when we have to compare it to upstream.
There was a problem hiding this comment.
I had the same thought, but it's only a single word, so I merged it. If you want to change it back, I'm not opposed.
There was a problem hiding this comment.
Given that the last update of that file is listed as 2013, I think it's safe to expect that we are never going to update this file. So maybe we shouldn't be overthinking this 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.