Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded duplicate words #2192

Merged
merged 1 commit into from
Jul 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dtoa.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
* FREE_DTOA_LOCK(...) are avoided; instead each thread with thread
* number < n has a separate copy of relevant data structures.
* After set_max_dtoa_threads(n), a call set_max_dtoa_threads(m)
* with m <= n has has no effect, but a call with m > n is honored.
* with m <= n has no effect, but a call with m > n is honored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not alter this file. We simply use an import of https://www.netlib.org/fp/, so we are not the source for this. Adding changes only add confusion when we have to compare it to upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thought, but it's only a single word, so I merged it. If you want to change it back, I'm not opposed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the last update of that file is listed as 2013, I think it's safe to expect that we are never going to update this file. So maybe we shouldn't be overthinking this 😅

* Such a call invokes REALLOC (assumed to be "realloc" if REALLOC
* is not #defined) to extend the size of the relevant array.
Expand Down
2 changes: 1 addition & 1 deletion test/natalie/complex_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
r.imaginary.should == 3
end

it 'does not have have Comparable mixin more than once' do
it 'does not have Comparable mixin more than once' do
Complex.ancestors.count(Comparable).should == 1
end
end
Loading