Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop Production: add/update human-readable/translatable crop names #1734

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emilyanndavis
Copy link
Member

Description

Fixes #614 and #1731.

Each crop supported by the Percentile model now has a human-readable/translatable name. These names were determined by cross-referencing Table 1 in Monfreda et. al. with the "EarthStat and FAO crop names and crop groups" table that is distributed alongside the datasets. When in doubt about how to resolve discrepancies, I sought additional context from the annexes of the FAO's World Programme for the Census of Agriculture 2020. See #614 for more details and links to sources.

In addition, sunflower has been restored to the Regression model's crop list, and the human-readable/translatable crop names there have been updated slightly for consistency with the Percentile model's crop list.

I didn't update HISTORY because the only place these changes will be apparent is in the User Guide, and we don't typically mention UG updates in the InVEST changelog.

Checklist

- [ ] Updated HISTORY.rst and link to any relevant issue

  • Tested the user's guide (builds successfully and renders crop names as expected)
    - [ ] Tested the Workbench UI (if relevant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations: decode Crop Production Percentile crop names
1 participant