Crop Production: add/update human-readable/translatable crop names #1734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #614 and #1731.
Each crop supported by the Percentile model now has a human-readable/translatable name. These names were determined by cross-referencing Table 1 in Monfreda et. al. with the "EarthStat and FAO crop names and crop groups" table that is distributed alongside the datasets. When in doubt about how to resolve discrepancies, I sought additional context from the annexes of the FAO's World Programme for the Census of Agriculture 2020. See #614 for more details and links to sources.
In addition,
sunflower
has been restored to the Regression model's crop list, and the human-readable/translatable crop names there have been updated slightly for consistency with the Percentile model's crop list.I didn't update HISTORY because the only place these changes will be apparent is in the User Guide, and we don't typically mention UG updates in the InVEST changelog.
Checklist
- [ ] Updated HISTORY.rst and link to any relevant issue- [ ] Tested the Workbench UI (if relevant)