Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MapQueryParameter): convert pcre regex to ecma #2435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xavierleune
Copy link
Contributor

Description

Hello everyone,
The current QueryParameterDescriber may generate an invalid definition, as we should have only ECMA 262 patterns.
This pull request ensure a better compliance, converting regexp to ecma syntax. It also fixes tests for the MapQueryParameterController, as in #2423 the namespace was not imported, so fixtures were incorrect.

Thanks !

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

@xavierleune xavierleune changed the title fix(MapQueryParameter) convert pcre regex to ecma MapQueryParameter: fix convert pcre regex to ecma Jan 21, 2025
@xavierleune xavierleune changed the title MapQueryParameter: fix convert pcre regex to ecma fix(MapQueryParameter): convert pcre regex to ecma Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (8b4803f) to head (43f4ea1).

Files with missing lines Patch % Lines
...entDescriber/SymfonyMapQueryParameterDescriber.php 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
+ Coverage   90.18%   90.20%   +0.01%     
==========================================
  Files          94       94              
  Lines        3067     3083      +16     
==========================================
+ Hits         2766     2781      +15     
- Misses        301      302       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant