Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive Microsoft Agent Framework integration to neo4j-agent-memory, targeting the preview release v1.0.0b251223. The integration provides context providers, chat message storage, GDS algorithms, memory tools, and reasoning trace recording capabilities.
Changes:
- 7 core integration modules for Microsoft Agent Framework support
- Complete retail assistant demo with backend (FastAPI) and frontend (Next.js)
- 61 tests (25 unit + 36 integration) with documentation
- 2 tutorial pages with 6 Excalidraw diagrams
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| src/neo4j_agent_memory/integrations/microsoft_agent/*.py | Core integration modules: memory, context provider, chat store, tools, GDS, tracing |
| tests/unit/integrations/test_microsoft_agent.py | Unit tests for integration components (552 lines) |
| examples/microsoft_agent_retail_assistant/ | Complete retail assistant demo (backend + frontend) |
| docs/tutorials/microsoft-agent-memory.adoc | Step-by-step tutorial for building shopping assistant |
| docs/how-to/integrations/microsoft-agent.adoc | Integration guide with API reference |
| pyproject.toml | Added microsoft-agent optional dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| elif tool_name == "recall_preferences": | ||
| prefs = await memory._client.long_term.search_preferences( |
There was a problem hiding this comment.
The create_memory_tools function signature includes parameters include_search, include_preferences, include_knowledge, include_traces, and include_gds that are referenced in the agent.py file (lines 397-401) but are not defined in the actual function signature (line 21-23 of tools.py). The function only accepts memory and include_gds_tools parameters. This will cause runtime errors when calling the function with these arguments.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
examples/microsoft_agent_retail_assistant/backend/tools/product_search.py
Outdated
Show resolved
Hide resolved
…t_search.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@johnymontana I've opened a new pull request, #34, to work on those changes. Once the pull request is ready, I'll request review from you. |
Updates the Microsoft Agent Framework provider to align with the latest `agent-framework`
This PR adds comprehensive support for Microsoft Agent Framework (
agent-frameworkPyPI package, v1.0.0b251223) to neo4j-agent-memory with graph-native memory capabilities.Key Features
Changes
Technical Notes
Test Results
All 61 tests passing, linting clean.