Skip to content

Comments

add Microsoft Agent Framework integration#33

Open
johnymontana wants to merge 19 commits intomainfrom
maf
Open

add Microsoft Agent Framework integration#33
johnymontana wants to merge 19 commits intomainfrom
maf

Conversation

@johnymontana
Copy link
Collaborator

@johnymontana johnymontana commented Jan 27, 2026

This PR adds comprehensive support for Microsoft Agent Framework (agent-framework PyPI package, v1.0.0b251223) to neo4j-agent-memory with graph-native memory capabilities.

Key Features

  • Neo4jContextProvider: Memory injection/extraction hooks
  • Neo4jChatMessageStore: Persistent chat history
  • Neo4jMicrosoftMemory: Unified interface
  • GDSIntegration: Graph algorithms with graceful fallback
  • 6 Memory Tools: search_memory, remember_preference, recall_preferences, search_knowledge, remember_fact, find_similar_tasks
  • Reasoning Traces: record_agent_trace(), get_similar_traces()

Changes

  • 7 core integration modules
  • Complete retail assistant demo (backend + frontend)
  • 2 documentation pages + 6 Excalidraw diagrams
  • 61 tests (25 unit + 36 integration)

Technical Notes

  • GDS fallback to basic Cypher when library not installed
  • Context composition from short-term, long-term, and reasoning memory

Test Results

All 61 tests passing, linting clean.

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-memory Ready Ready Preview, Comment Feb 18, 2026 5:18am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive Microsoft Agent Framework integration to neo4j-agent-memory, targeting the preview release v1.0.0b251223. The integration provides context providers, chat message storage, GDS algorithms, memory tools, and reasoning trace recording capabilities.

Changes:

  • 7 core integration modules for Microsoft Agent Framework support
  • Complete retail assistant demo with backend (FastAPI) and frontend (Next.js)
  • 61 tests (25 unit + 36 integration) with documentation
  • 2 tutorial pages with 6 Excalidraw diagrams

Reviewed changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated 17 comments.

Show a summary per file
File Description
src/neo4j_agent_memory/integrations/microsoft_agent/*.py Core integration modules: memory, context provider, chat store, tools, GDS, tracing
tests/unit/integrations/test_microsoft_agent.py Unit tests for integration components (552 lines)
examples/microsoft_agent_retail_assistant/ Complete retail assistant demo (backend + frontend)
docs/tutorials/microsoft-agent-memory.adoc Step-by-step tutorial for building shopping assistant
docs/how-to/integrations/microsoft-agent.adoc Integration guide with API reference
pyproject.toml Added microsoft-agent optional dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +395 to +396
elif tool_name == "recall_preferences":
prefs = await memory._client.long_term.search_preferences(
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create_memory_tools function signature includes parameters include_search, include_preferences, include_knowledge, include_traces, and include_gds that are referenced in the agent.py file (lines 397-401) but are not defined in the actual function signature (line 21-23 of tools.py). The function only accepts memory and include_gds_tools parameters. This will cause runtime errors when calling the function with these arguments.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

…t_search.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
johnymontana and others added 2 commits January 27, 2026 15:01
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI commented Jan 27, 2026

@johnymontana I've opened a new pull request, #34, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants