Skip to content

Comments

Fix create_memory_tools() call signature in retail assistant example#34

Open
Copilot wants to merge 2 commits intomaffrom
copilot/sub-pr-33
Open

Fix create_memory_tools() call signature in retail assistant example#34
Copilot wants to merge 2 commits intomaffrom
copilot/sub-pr-33

Conversation

Copy link

Copilot AI commented Jan 27, 2026

The create_memory_tools() function was being called with parameters that don't exist in its signature, causing runtime errors when initializing the agent.

Changes:

  • Fixed function call in examples/microsoft_agent_retail_assistant/backend/agent.py to match actual signature
  • Added required memory parameter
  • Replaced invalid parameters with include_gds_tools

Before:

memory_tools = create_memory_tools(
    include_search=True,
    include_preferences=True,
    include_knowledge=True,
    include_traces=False,
    include_gds=True,
)

After:

memory_tools = create_memory_tools(
    memory=memory,
    include_gds_tools=True,
)

The function signature only accepts memory: Neo4jMicrosoftMemory and include_gds_tools: bool parameters.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
agent-memory Ready Ready Preview, Comment Jan 27, 2026 10:06pm

…er and use correct parameter name

Co-authored-by: johnymontana <1222454+johnymontana@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP to address feedback on Microsoft Agent Framework integration Fix create_memory_tools() call signature in retail assistant example Jan 27, 2026
Copilot AI requested a review from johnymontana January 27, 2026 22:08
@johnymontana johnymontana marked this pull request as ready for review February 6, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants