This repository has been archived by the owner on May 16, 2022. It is now read-only.
Fix #128 #129
Open
Fix #128 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, please! Why is it, steel not in master? @neuecc |
|
Can we get this into the master already please.? |
rimonhanna
approved these changes
May 4, 2020
|
Please merge this changes. This fix is important. @neuecc |
|
I ended up here because I got the ArgumentException "Key was already exists. Key:" exception when trying to serialize a class with an enum and googled it. Part from the functional aspects of the exception, fix the grammar in the exception argument as well. Not that it really matters but it looks kinda bad. Suggestion: "Key already exist. Key:" or perhaps "Duplicate Key"... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #128.