Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer docs to ensure compatibility with latest scikit-learn. #319

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

ryanhausen
Copy link
Contributor

Reference Issues/PRs

Fixes #314

What does this implement/fix? Explain your changes.

This addresses an issue that can happen if the neurodata/scikit-learn branch of scikit-learn is not compatable with the current stable release of scikit-learn, which can cause tests in treeple to fail.

Any other comments?

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.00%. Comparing base (1d970b0) to head (3b10af5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files          24       24           
  Lines        2221     2221           
  Branches      411      411           
=======================================
  Hits         1777     1777           
  Misses        312      312           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392 adam2392 merged commit bcf4b12 into neurodata:main Sep 5, 2024
35 checks passed
@adam2392
Copy link
Collaborator

adam2392 commented Sep 5, 2024

Thanks @ryanhausen !

@ryanhausen ryanhausen deleted the issue-314 branch September 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants