Add unit tests for fit_ellipse_to_points center estimation#60
Open
AlgoFoe wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Open
Add unit tests for fit_ellipse_to_points center estimation#60AlgoFoe wants to merge 1 commit intoneuroinformatics-unit:mainfrom
AlgoFoe wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
fit_ellipse_to_pointsfunction did not have dedicated unit tests and this made it difficult to verify the correctness of the fitted ellipse parameters, particularly the ellipse center.What does this PR do?
fit_ellipse_to_pointsthat validate correct recovery of the ellipse center.References
fit_ellipse_to_points#36How has this PR been tested?
pytest.Is this a breaking change?
Does this PR require an update to the documentation?
Checklist: