fix: comment adding of communication link to dynamic link contacts

[shielasabellita]

Asana: https://app.asana.com/0/1203283251131831/1207895033520677/f

Issue:
NEXT Master contacts are used to link email to particular Customer/Supplier. With this, if it is linked to multiple customers, any notification made from user will populate to the timeline of the linked customer or supplier which it should not because it is not relevant.

Fix:
Except the NEXT Master contact in adding timeline links whenever a notification to the customer/supplier is made.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dottenbr]

I don't like this solution, we are assuming that a user always has "next master" in his name, but they don't necessarily have that.

[shielasabellita]

Noted on this, Dominik. Thank you for the review.

[shielasabellita]

• Removed the next master keyword validation
• Add a condition to don't create a timeline links if the Reference Doctype and Contact link is not the same

[dottenbr]

I don't completely understand the change but if this makes sense to everyone, wouldn't this be a good thing to have in Open Source so we don't have to maintain?

[shielasabellita]

According to the documention, emailing linking to Customer or Supplier and as well as Contact is used for Email Aggregation. But in our case, it should not display to Timeline because the information are unrelated or should not be displayed to the Customer or Supplier timeline.

[shielasabellita]

Pushed a new code that will just comment the function that creates a TImeline Links base from the Contact's dynamic links.

[shielasabellita]

As per discussion, there are other information that should be shown Customer/Supplier timeline logs. E.g. made an email from Sales Invoice, since Sales Invoice has connection to Customer, then a timeline should be created in both Sales Invoice, Customer. As well as Contact.

In this PR, this will not create a link to every connected dynamic link. Thus, closing this for rework.