Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment adding of communication link to dynamic link contacts #90

Closed
wants to merge 2 commits into from
Closed

fix: comment adding of communication link to dynamic link contacts #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed646c
fix(timeline_links): dont create if contact link and ref is not the same
shielasabellita Aug 1, 2024
de5d072
fix: comment adding of commonucation link to dynamic link contacts
shielasabellita Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frappe/core/doctype/communication/communication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def set_timeline_links(self):
self.add_link("Contact", contact_name)

# link contact's dynamic links to communication
add_contact_links_to_communication(self, contact_name)
# add_contact_links_to_communication(self, contact_name) # Commented out as the dynamic links: Customer/Supplier should not be linked to communication only on Contact timeline

def deduplicate_timeline_links(self):
if self.timeline_links:
Expand Down Expand Up @@ -592,3 +592,4 @@ def set_avg_response_time(parent, communication):
if response_times:
avg_response_time = sum(response_times) / len(response_times)
parent.db_set("avg_response_time", avg_response_time)