chore(release): add RELEASE_TOKEN to the environment of the release task #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-new-relic
commented
Sep 4, 2024
Comment on lines
+33
to
+34
| env: | ||
| GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }} |
There was a problem hiding this comment.
adding this here because this is where the release script is failing; the script enters the bash file and then fails at the step when it's supposed to publish the release, possibly because it doesn't have a RELEASE_TOKEN in the environment to authorize/validate the release runner, our bot.
In other words, making this similar to
etc.
NSSPKrishna
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
release-auto.sh(Release Script) doesn't seem to be working when triggered by the release workflowrelease.yml, and is failing with an error which hints at the fact that an unauthorized (non-bot) GitHub user is trying to perform the release.It is clear from the rest of the configuration that the username and email of the user configured to perform the release are that of our DTK Bot, but this still doesn't seem to be working, hinting at the fact that this could be possibly an issue caused by a missing
RELEASE_TOKEN; hence the update. See the comment below for more info.