Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): add RELEASE_TOKEN to the environment of the release task #73

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore(release): add RELEASE_TOKEN to the environment of the release task #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ jobs:

- name: Release
shell: bash
env:
GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}
Comment on lines +33 to +34
Copy link
Member Author

@pranav-new-relic pranav-new-relic Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this here because this is where the release script is failing; the script enters the bash file and then fails at the step when it's supposed to publish the release, possibly because it doesn't have a RELEASE_TOKEN in the environment to authorize/validate the release runner, our bot.

In other words, making this similar to

https://github.com/newrelic/newrelic-client-go/blob/2785c31e58443ef35d5f3872b3b930d6d595225d/.github/workflows/release.yml#L30-L39

https://github.com/newrelic/newrelic-cli/blob/d5b5d3f8d309c188c980218c030f22560f856b67/.github/workflows/release.yml#L53-L56

etc.

run: |
git config --global user.name ${{ secrets.NEW_RELIC_GITHUB_SERVICE_ACCOUNT_USERNAME }}
git config --global user.email ${{ secrets.NEW_RELIC_GITHUB_SERVICE_ACCOUNT_EMAIL }}
Expand Down
Loading