fix: improve handling of .NET environments and settings from appsettings.*.json files #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
=======================================
Coverage 81.06% 81.06%
=======================================
Files 395 395
Lines 24718 24724 +6
Branches 2971 2970 -1
=======================================
+ Hits 20037 20043 +6
Misses 3895 3895
Partials 786 786
|
nr-ahemsath
requested review from
a team,
jaffinito,
nrcventura,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
tippmar-nr
approved these changes
Dec 7, 2023
nrcventura
approved these changes
Dec 7, 2023
chynesNR
approved these changes
Dec 7, 2023
nr-ahemsath
deleted the
bugfix/better-appsettings-environment-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2081 by adding
appsettings.Production.jsonto the list of files to search by default for New Relic config settings. In addition, the agent will now look atDOTNET_ENVIRONMENTin addition toASPNETCORE_ENVIRONMENTto determine the specific environment configured for the agent.