-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle null or empty SQS messages and/or message attributes #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrcventura
previously approved these changes
Oct 14, 2024
tippmar-nr
reviewed
Oct 15, 2024
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/AwsSdk/SQSRequestHandler.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
reviewed
Oct 15, 2024
...gent/IntegrationTests/ContainerApplications/AwsSdkTestApp/AwsSdkExerciser/AwsSdkExerciser.cs
Outdated
Show resolved
Hide resolved
…wrelic/newrelic-dotnet-agent into fix/handle-null-or-empty-messages-sqs
nrcventura
previously approved these changes
Oct 15, 2024
tippmar-nr
previously approved these changes
Oct 15, 2024
tippmar-nr
approved these changes
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
=======================================
Coverage 81.31% 81.31%
=======================================
Files 460 460
Lines 29239 29239
Branches 3231 3231
=======================================
Hits 23777 23777
Misses 4669 4669
Partials 793 793
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nrcventura
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2811.
The SQS wrapper is updated to check for:
before attempting to accept tracing headers from the message attributes.
The SQS integration tests are updated to:
AWSConfigs.InitializeCollections
either true (default) or false (the condition that surfaced this bug)