Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving cloud SDK attributes to Segments #2924

Conversation

chynesNR
Copy link
Member

@chynesNR chynesNR commented Dec 9, 2024

Using this separate PR to discuss the pros and cons of moving the new Cloud SDK attributes out of Transaction metadata. The goal would be to support multiple AWS services per transaction.

@chynesNR chynesNR requested a review from a team as a code owner December 9, 2024 21:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (55cc8a4) to head (97bc3ec).

Files with missing lines Patch % Lines
src/Agent/NewRelic/Agent/Core/Segments/Segment.cs 0.00% 8 Missing ⚠️
.../Agent/NewRelic/Agent/Core/Segments/NoOpSegment.cs 0.00% 3 Missing ⚠️
...gent/Core/Attributes/AttributeDefinitionService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           feature/invoke-lambda-instrumentation    #2924   +/-   ##
======================================================================
  Coverage                                  81.45%   81.45%           
======================================================================
  Files                                        467      467           
  Lines                                      29723    29727    +4     
  Branches                                    3309     3309           
======================================================================
+ Hits                                       24210    24214    +4     
+ Misses                                      4717     4716    -1     
- Partials                                     796      797    +1     
Flag Coverage Δ
Agent 82.37% <0.00%> (+<0.01%) ⬆️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nt/NewRelic/Agent/Core/Transactions/Transaction.cs 80.73% <ø> (+0.18%) ⬆️
...gent/Core/Attributes/AttributeDefinitionService.cs 94.24% <0.00%> (-0.13%) ⬇️
.../Agent/NewRelic/Agent/Core/Segments/NoOpSegment.cs 10.25% <0.00%> (-0.86%) ⬇️
src/Agent/NewRelic/Agent/Core/Segments/Segment.cs 89.02% <0.00%> (-3.00%) ⬇️

... and 2 files with indirect coverage changes

@chynesNR chynesNR merged commit 8d41f54 into feature/invoke-lambda-instrumentation Dec 10, 2024
94 checks passed
@chynesNR chynesNR deleted the feature-work/cloud-attributes-on-segments branch December 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants