Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vue3): migrate deprecated slot syntax #5715

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 24, 2024

Fix #5694

I tested all migrated components locally for visual regressions.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e6e8c2a) 24.41% compared to head (3d18fe1) 24.37%.
Report is 16 commits behind head on main.

Files Patch % Lines
...ppointmentConfigList/AppointmentConfigListItem.vue 0.00% 4 Missing ⚠️
...s/AppointmentConfigModal/NoEmailAddressWarning.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5715      +/-   ##
============================================
- Coverage     24.41%   24.37%   -0.05%     
  Complexity      418      418              
============================================
  Files           243      243              
  Lines         10874    10892      +18     
  Branches       1790     1790              
============================================
  Hits           2655     2655              
- Misses         8219     8237      +18     
Flag Coverage Δ
javascript 15.47% <0.00%> (-0.04%) ⬇️
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit 54dfad2 into main Jan 24, 2024
35 of 37 checks passed
@st3iny st3iny deleted the chore/vue3/migrate-deprecated-slot-syntax branch January 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate deprecated slot syntax
2 participants