Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vue3): migrate deprecated slot syntax #5715

Merged
merged 1 commit into from
Jan 24, 2024
Merged

chore(vue3): migrate deprecated slot syntax #5715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/components/AppNavigation/AppointmentConfigList/AppointmentConfigListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,31 @@
<template #actions>
<ActionLink :href="config.bookingUrl"
target="_blank">
<OpenInNewIcon slot="icon" :size="20" decorative />
<template #icon>
<OpenInNewIcon :size="20" />
</template>
{{ t('calendar', 'Preview') }}
</ActionLink>
<ActionButton v-if="hasClipboard"
:close-after-click="true"
@click="copyLink">
<LinkVariantIcon slot="icon" :size="20" decorative />
<template #icon>
<LinkVariantIcon :size="20" />
</template>

Check warning on line 43 in src/components/AppNavigation/AppointmentConfigList/AppointmentConfigListItem.vue

View check run for this annotation

Codecov / codecov/patch

src/components/AppNavigation/AppointmentConfigList/AppointmentConfigListItem.vue#L42-L43 

Added lines #L42 - L43 were not covered by tests
{{ t('calendar', 'Copy link') }}
</ActionButton>
<ActionButton :close-after-click="true"
@click="showModal = true">
<PencilIcon slot="icon" :size="20" decorative />
<template #icon>

Check warning on line 48 in src/components/AppNavigation/AppointmentConfigList/AppointmentConfigListItem.vue

View check run for this annotation

Codecov / codecov/patch

src/components/AppNavigation/AppointmentConfigList/AppointmentConfigListItem.vue#L48 

Added line #L48 was not covered by tests
<PencilIcon :size="20" />
</template>

Check warning on line 50 in src/components/AppNavigation/AppointmentConfigList/AppointmentConfigListItem.vue

View check run for this annotation

Codecov / codecov/patch

src/components/AppNavigation/AppointmentConfigList/AppointmentConfigListItem.vue#L50 

Added line #L50 was not covered by tests
{{ t('calendar', 'Edit') }}
</ActionButton>
<ActionButton :close-after-click="true"
@click="$emit('delete', $event)">
<DeleteIcon slot="icon" :size="20" decorative />
<template #icon>
<DeleteIcon :size="20" />
</template>
{{ t('calendar', 'Delete') }}
</ActionButton>
</template>
Expand Down
13 changes: 7 additions & 6 deletions src/components/AppNavigation/CalendarList/PublicCalendarListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,20 @@
:title="calendar.displayName || $t('calendar', 'Untitled calendar')"
:menu-open.sync="menuOpen"
@click.prevent.stop="toggleEnabled">
<AppNavigationIconBullet v-if="calendar.enabled"
slot="icon"
:color="calendar.color"
@click.prevent.stop="toggleEnabled" />
<template #icon>
<AppNavigationIconBullet v-if="calendar.enabled"
:color="calendar.color"
@click.prevent.stop="toggleEnabled" />
</template>

<template slot="counter">
<template #counter>
<Avatar :user="owner"
:is-guest="true"
:disable-tooltip="true"
:disable-menu="true" />
</template>

<template slot="actions">
<template #actions>
<ActionButton v-if="showCopySubscriptionLinkLabel"
@click.prevent.stop="copySubscriptionLink">
<template #icon>
Expand Down
4 changes: 3 additions & 1 deletion src/components/AppNavigation/EditCalendarModal/SharingSearch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@
label="displayName"
@search="findSharee"
@option:selected="shareCalendar">
<span slot="no-options">{{ $t('calendar', 'No users or groups') }}</span>
<template #no-options>
<span>{{ $t('calendar', 'No users or groups') }}</span>
</template>
</NcSelect>
</div>
</template>
Expand Down Expand Up @@ -94,9 +96,9 @@
/**
* Function to filter results in NcSelect
*
* @param {object} option

Check warning on line 99 in src/components/AppNavigation/EditCalendarModal/SharingSearch.vue

View workflow job for this annotation

GitHub Actions / eslint 

Missing JSDoc @param "option" description
* @param {string} label

Check warning on line 100 in src/components/AppNavigation/EditCalendarModal/SharingSearch.vue

View workflow job for this annotation

GitHub Actions / eslint 

Missing JSDoc @param "label" description
* @param {string} search

Check warning on line 101 in src/components/AppNavigation/EditCalendarModal/SharingSearch.vue

View workflow job for this annotation

GitHub Actions / eslint 

Missing JSDoc @param "search" description
*/
filterResults(option, label, search) {
return true
Expand Down
4 changes: 3 additions & 1 deletion src/components/AppointmentConfigModal/NoEmailAddressWarning.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
<template>
<AppNavigationItem :title="title"
@click="openUserSettings">
<AlertCircleIcon slot="icon" :size="20" decorative />
<template #icon>

Check warning on line 26 in src/components/AppointmentConfigModal/NoEmailAddressWarning.vue

View check run for this annotation

Codecov / codecov/patch

src/components/AppointmentConfigModal/NoEmailAddressWarning.vue#L26 

Added line #L26 was not covered by tests
<AlertCircleIcon :size="20" />
</template>
</AppNavigationItem>
</template>

Expand Down
Loading