-
Notifications
You must be signed in to change notification settings - Fork 286
fix: list separators depending on sort by date #11708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the category sort order thingy fixed we discussed at the conference?
c898292
to
c1cfdc3
Compare
no, but i cannot reproduce it anymore because now that small inbox has more emails because of other tests. So, its a very specific scenario that it fails. |
I pushed fixes for my reviews. |
2688c30
to
a7ea8ed
Compare
/backport to stable5.5 |
js unit tests fail |
|
Signed-off-by: greta <gretadoci@gmail.com>
a4cc5aa
to
1af3195
Compare
fixes #11567
Also changes the sorting from:
['lastHour', 'today', 'yesterday', 'lastWeek', 'lastMonth']
to
['lastHour', 'today', 'yesterday', 'lastWeek', 'lastMonth', 'Months', 'Years' ]