Skip to content

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 17, 2025

fixes #11567

Also changes the sorting from:

['lastHour', 'today', 'yesterday', 'lastWeek', 'lastMonth']
to
['lastHour', 'today', 'yesterday', 'lastWeek', 'lastMonth', 'Months', 'Years' ]

@GretaD GretaD marked this pull request as ready for review October 2, 2025 11:01
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the category sort order thingy fixed we discussed at the conference?

@GretaD GretaD force-pushed the fix/sort-order-recent-month-year branch from c898292 to c1cfdc3 Compare October 7, 2025 14:53
@GretaD
Copy link
Contributor Author

GretaD commented Oct 7, 2025

Is the category sort order thingy fixed we discussed at the conference?

no, but i cannot reproduce it anymore because now that small inbox has more emails because of other tests. So, its a very specific scenario that it fails.

st3iny

This comment was marked as resolved.

st3iny
st3iny previously requested changes Oct 8, 2025
@st3iny
Copy link
Member

st3iny commented Oct 8, 2025

I pushed fixes for my reviews.

@GretaD GretaD requested a review from st3iny October 9, 2025 14:07
@GretaD GretaD force-pushed the fix/sort-order-recent-month-year branch from 2688c30 to a7ea8ed Compare October 10, 2025 14:51
@ChristophWurst
Copy link
Member

/backport to stable5.5

@ChristophWurst
Copy link
Member

js unit tests fail

@ChristophWurst
Copy link
Member

  FAIL  src/tests/unit/util/groupedEnvelopes.spec.js > groupEnvelopesByDate > groups envelopes into lastHour, yesterday, lastMonth, July, and 2024
AssertionError: expected [ '0', '1', '2', '3', '4' ] to deeply equal ArrayContaining{…}

- Expected
+ Received

- ArrayContaining [
-   "lastHour",
-   "yesterday",
-   "lastMonth",
-   "July",
-   "2024",
+ [
+   "0",
+   "1",
+   "2",
+   "3",
+   "4",
  ]

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the fix/sort-order-recent-month-year branch from a4cc5aa to 1af3195 Compare October 13, 2025 18:52
@ChristophWurst ChristophWurst merged commit c1b96fe into main Oct 15, 2025
44 checks passed
@ChristophWurst ChristophWurst deleted the fix/sort-order-recent-month-year branch October 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorting broken with new grouping feature

3 participants