-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon): Reset SelectOption if value is not in values #1079
feat(neon): Reset SelectOption if value is not in values #1079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you made sure that the push distributor option still works?
Some options (initialApp, initialAccount and pushNotificationsDistributor) don't have initial values
. Therefore the reset might conflict with loading the initial value
.
I currently could only test the first two this sorry 😅
It might not be a problem as the forceload
parameter isn't used anywhere (we could maybe remove it in a followup).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the first two commits
You were right, I changed it so it only sets I'll do some testing on all these options. |
6c80d47
to
4f94102
Compare
I tested the 3 critical options and they all still work as expected. |
Signed-off-by: jld3103 <jld3103yt@gmail.com>
…id values Signed-off-by: jld3103 <jld3103yt@gmail.com>
4f94102
to
172bc9d
Compare
The problem of the disappearing initial app is fixed in #1310 |
Towards #892, but it doesn't fix it because the AppsBloc is still making problems.