Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon): Reset SelectOption if value is not in values #1079

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

provokateurin
Copy link
Member

Towards #892, but it doesn't fix it because the AppsBloc is still making problems.

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you made sure that the push distributor option still works?
Some options (initialApp, initialAccount and pushNotificationsDistributor) don't have initial values. Therefore the reset might conflict with loading the initial value.
I currently could only test the first two this sorry 😅

It might not be a problem as the forceload parameter isn't used anywhere (we could maybe remove it in a followup).

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the first two commits

@provokateurin
Copy link
Member Author

Some options (initialApp, initialAccount and pushNotificationsDistributor) don't have initial values. Therefore the reset might conflict with loading the initial value.

You were right, I changed it so it only sets _value. Once the values are set they will validate that the loaded value is correct.

I'll do some testing on all these options.

@provokateurin provokateurin force-pushed the feature/neon/settings-reset-invalid-values branch from 6c80d47 to 4f94102 Compare November 17, 2023 12:21
@provokateurin
Copy link
Member Author

I tested the 3 critical options and they all still work as expected.

Signed-off-by: jld3103 <jld3103yt@gmail.com>
…id values

Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the feature/neon/settings-reset-invalid-values branch from 4f94102 to 172bc9d Compare December 16, 2023 13:17
@provokateurin
Copy link
Member Author

The problem of the disappearing initial app is fixed in #1310

@provokateurin provokateurin merged commit a4b685c into main Dec 16, 2023
8 checks passed
@provokateurin provokateurin deleted the feature/neon/settings-reset-invalid-values branch December 16, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants