Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextcloud)!: Revert request body usage for non-PUT/POST/PATCH requests #2352

Merged
merged 2 commits into from
Aug 6, 2024

fix(nextcloud)!: Revert request body usage for non-PUT/POST/PATCH req…

52f868d
Select commit
Loading
Failed to load commit list.
Merged

fix(nextcloud)!: Revert request body usage for non-PUT/POST/PATCH requests #2352

fix(nextcloud)!: Revert request body usage for non-PUT/POST/PATCH req…
52f868d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 6, 2024 in 1s

25.46% (+0.23%) compared to da4bff1

View this Pull Request on Codecov

25.46% (+0.23%) compared to da4bff1

Details

Codecov Report

Attention: Patch coverage is 15.64792% with 345 lines in your changes missing coverage. Please review.

Project coverage is 25.46%. Comparing base (da4bff1) to head (52f868d).
Report is 3 commits behind head on main.

Files Patch % Lines
...b/src/api/files_sharing/files_sharing.openapi.dart 6.45% 87 Missing ⚠️
...api/provisioning_api/provisioning_api.openapi.dart 6.66% 56 Missing ⚠️
...nextcloud/lib/src/api/theming/theming.openapi.dart 12.50% 42 Missing ⚠️
...i/provisioning_api/provisioning_api.openapi.g.dart 0.00% 30 Missing ⚠️
...src/api/files_trashbin/files_trashbin.openapi.dart 6.66% 28 Missing ⚠️
...s/nextcloud/lib/src/api/tables/tables.openapi.dart 0.00% 19 Missing ⚠️
...src/api/files_sharing/files_sharing.openapi.g.dart 0.00% 18 Missing ⚠️
...xtcloud/lib/src/api/theming/theming.openapi.g.dart 0.00% 18 Missing ⚠️
...src/api/files_versions/files_versions.openapi.dart 0.00% 16 Missing ⚠️
...cloud/lib/src/api/user_ldap/user_ldap.openapi.dart 12.50% 14 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
+ Coverage   25.23%   25.46%   +0.23%     
==========================================
  Files         333      333              
  Lines      140016   134828    -5188     
==========================================
- Hits        35331    34336     -995     
+ Misses     104685   100492    -4193
Files Coverage Δ
...s/neon/neon_dashboard/lib/src/blocs/dashboard.dart 100.00% <100.00%> (ø)
packages/neon/neon_talk/lib/src/blocs/room.dart 98.52% <100.00%> (-0.09%) ⬇️
.../neon/neon_talk/lib/src/widgets/message_input.dart 98.56% <100.00%> (-0.04%) ⬇️
...talk/lib/src/widgets/rich_object/file_preview.dart 100.00% <100.00%> (ø)
...s/neon_framework/lib/src/blocs/unified_search.dart 100.00% <100.00%> (ø)
...es/neon_framework/lib/src/testing/mock_server.dart 91.66% <100.00%> (ø)
...s/neon_framework/lib/src/widgets/autocomplete.dart 100.00% <100.00%> (+2.27%) ⬆️
...kages/nextcloud/lib/src/api/core/core.openapi.dart 45.44% <ø> (+0.07%) ⬆️
...ges/nextcloud/lib/src/api/core/core.openapi.g.dart 29.21% <ø> (+0.04%) ⬆️
...cloud/lib/src/api/dashboard/dashboard.openapi.dart 86.61% <100.00%> (+1.63%) ⬆️
... and 21 more

... and 7 files with indirect coverage changes

View more details on Codecov