Skip to content

fix(migrations): Restore type definitions for API class used in apps#58399

Merged
nickvergessen merged 1 commit intomasterfrom
followup/58282/restore-typing-on-middle-class
Feb 18, 2026
Merged

fix(migrations): Restore type definitions for API class used in apps#58399
nickvergessen merged 1 commit intomasterfrom
followup/58282/restore-typing-on-middle-class

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 18, 2026

Before

ERROR: MoreSpecificImplementedParamType - lib/Migration/Version23000Date20260107162758.php:30:56 - Argument 2 of OCA\Talk\Migration\Version23000Date20260107162758::changeSchema has the more specific type 'Closure():OCP\DB\ISchemaWrapper', expecting 'Closure' as defined by OCP\Migration\SimpleMigrationStep::changeSchema (see https://psalm.dev/140)
	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {

Option1 (bad) - Remove docs in Talk

Before removing Talk docs After
Bildschirmfoto vom 2026-02-18 08-49-53 Bildschirmfoto vom 2026-02-18 08-50-06
Types are hinted and parameter name of createTable is known Types are lost, no hinting

Option2 (better) - Restore the docs on SimpleMigrationStep

------------------------------
                              
       No errors found!       
                              
------------------------------

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 34 milestone Feb 18, 2026
@nickvergessen nickvergessen requested a review from a team as a code owner February 18, 2026 07:38
@nickvergessen nickvergessen removed the request for review from a team February 18, 2026 07:38
@nickvergessen nickvergessen self-assigned this Feb 18, 2026
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen nickvergessen merged commit a6d1fa1 into master Feb 18, 2026
178 of 180 checks passed
@nickvergessen nickvergessen deleted the followup/58282/restore-typing-on-middle-class branch February 18, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants