refactor(psalm): Modernize migration doc#58282
Merged
Conversation
And remove all the duplication in the subclasses Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/refactor-migration
branch
from
574f6b2 to
f6c839d
Compare
CarlSchwan
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
salmart-dev
and removed request for
a team
10 tasks
provokateurin
approved these changes
Feb 12, 2026
cristianscheid
approved these changes
Feb 13, 2026
susnux
approved these changes
Feb 13, 2026
Comment on lines
-38
to
-42
| * @param IOutput $output | ||
| * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper` | ||
| * @psalm-param Closure():ISchemaWrapper $schemaClosure | ||
| * @param array $options | ||
| * @since 13.0.0 |
Member
There was a problem hiding this comment.
The wiping of these comments breaks psalm in apps:
ERROR: MoreSpecificImplementedParamType - lib/Migration/Version23000Date20260123100000.php:37:82 - Argument 3 of OCA\Talk\Migration\Version23000Date20260123100000::postSchemaChange has the more specific type 'array{tablePrefix?: string}', expecting 'array<array-key, mixed>' as defined by OCP\Migration\SimpleMigrationStep::postSchemaChange (see https://psalm.dev/140)
public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
Contributor
There was a problem hiding this comment.
but it should be already inherited from IMigrationStep?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove all the duplication in the subclasses
Summary
TODO
Checklist
3. to review, feature component)stable32)