Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement permission check for notifications on Android 13 #3210

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Implement permission check for notifications on Android 13 #3210

merged 1 commit into from
Jul 27, 2023

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jul 26, 2023 •
edited
Loading

Resolves #3123

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 17.1.0 milestone Jul 26, 2023
@AndyScherzinger
Copy link
Member Author

/backport to stable-17.0

@AndyScherzinger AndyScherzinger added bug Something isn't working technical debt Technical issue labels Jul 26, 2023
@AndyScherzinger
implement permission check for notifications on Android 13
c0deca5 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3210-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger merged commit 8bef585 into master Jul 27, 2023
14 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fixNotificationPermissions branch July 27, 2023 06:17
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 27, 2023
Merged
@mahibi mahibi mentioned this pull request Aug 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working technical debt Technical issue
Projects
None yet
Milestone
17.1.0
Development

Successfully merging this pull request may close these issues.

warn when notifications in android settings are blocked for the talk app
1 participant
@AndyScherzinger