Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest: fetch and append pathoplexus global lineage calls #40

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

j23414
Copy link
Collaborator

@j23414 j23414 commented Nov 3, 2024

Description of proposed changes

This pull request adds rules to retrieve global lineage (1A, 1B, 2, 3, 4, 5, 7, 8) calls from the Pathoplexus website. After appending the Pathoplexus lineages, we can color the tree as shown at https://next.nextstrain.org/staging/WNV/pathoplexus?c=lineage

Screenshot 2024-11-02 at 6 00 45 PM

This change has the added benefit of restricting the USA-based clade calls to the 1A strains (which include most North American WNV strains) since they are based on an initial WNV case isolated in New York from 1999.

Left (original global tree); Right (fixed global tree, where USA-based clade calls restricted to 1A strains)

Screenshot 2024-11-02 at 6 01 14 PM

The updated tree can be viewed at https://next.nextstrain.org/staging/WNV/pathoplexus?c=clade_membership

Related issue(s)

Checklist

  • Checks pass

* Pull `lineage` global assignments from Pathoplexus
* Identify potential 1A lineage strains
* Only run the usa-based nextclade calls on the 1A lineage strains
@j23414 j23414 linked an issue Nov 3, 2024 that may be closed by this pull request
9 tasks
@tsibley
Copy link
Member

tsibley commented Nov 7, 2024

FWIW, Pathoplexus is using the Nextclade dataset nextstrain/wnv/all-lineages to make those lineage calls. Not sure if you were aware or not, so thought I'd mention it. From a reliability and robustness perspective, it'd be better to run nextclade ourselves to make those calls rather than pull from Pathoplexus.

@j23414
Copy link
Collaborator Author

j23414 commented Nov 7, 2024

Thanks @tsibley! I should have documented that @joverlee521 tracked down the nextstrain/wnv/all-lineages dataset to a draft pull request. Extracting a nextclade dataset from a draft branch seemed fragile, therefore I opted for test driving the public facing Pathoplexus API.

Once the nextstrain/wnv/all-lineages dataset is merged and properly documented, I'm happy to transition to using a nextclade call!

@tsibley
Copy link
Member

tsibley commented Nov 8, 2024

Ah, ok. Fair enough. I'll note that the dataset is still obtainable with nextclade dataset get and can be pinned to the specific current commit of that PR so that any future changes to the wnv branch aren't automatically pulled in.

nextclade dataset get \
  --name nextstrain/wnv/all-lineages \
  --server https://raw.githubusercontent.com/nextstrain/nextclade_data/8f2e791d3a59013ee88e1d1d7e83b486d39c4ecb/data_output \
  --output-zip wnv.zip

But point taken about it being only in a draft PR; I hadn't clocked that!

Copy link
Collaborator

@DOH-LMT2303 DOH-LMT2303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the Pathoplexus lineages are in agreement with the topology of the tree and the literature. However, there is need to double check the classification of PP445212 as Pathoplexus lineage 3, because only lineage 1a has been detected in North America at least until the publication of this paper Koch. et al. 2023.

@j23414
Copy link
Collaborator Author

j23414 commented Nov 13, 2024

PP445212 is strange! I tracked it down to a mixed lineage 1 and 3 infection in Nebraska reported by the CDC in 2024. As far as I can see, there doesn't seem to be a persistent detection of lineage 3 in North America following that case. 🤞

@j23414 j23414 merged commit 3556b10 into main Nov 13, 2024
4 checks passed
@j23414 j23414 deleted the append-pathoplexus-wnv-lineage-calls branch November 13, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perhaps append Pathoplexus WNV lineage calls
3 participants