feat(mask): allow empty mask file, warn not error #1287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This commit adds a warning message when encountering an empty mask file. Now, instead of throwing an error, a warning is printed with the name of the empty mask file.
Reason: When stubbing out a build, one may want to add an empty mask file to future proof the repo even if that list of sites is empty
Also: When one just has one masked site, removes it from the file, one generally doesn't want the workflow to error
Config file changes, e.g. removing mask sites, shouldn't cause workflows to error. This is arguably a bug.
Testing
Tested in a few repos that nothing breaks and no more error when file is empty
Checklist