Move failure reporting to reusable workflow #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing to lift this entire job to a reusable workflow, where these variables can easily be replaced by inputs.
Preparing to lift this entire job to a reusable workflow.
Workflow path extraction was co-authored by ChatGPT. Prompt:
I have a bash variable "workflow_ref" in the format
"<unnecessary_text>/.github/workflows/<name>.yml@<unnecessary_text>".
Write a bash script to extract everything but <unnecessary text>, and
drop the trailing '@'.
2 tasks
The code has been relocated.
victorlin
force-pushed
the
victorlin/reusable-failure-reporting
branch
from
4bb7556 to
a4c8dda
Compare
victorlin
commented
Feb 14, 2025
| success: ${{ needs.test.result == 'success' }} | ||
| title: Installation failure | ||
| secrets: | ||
| token: ${{ secrets.GH_TOKEN_NEXTSTRAIN_BOT_REPO }} |
There was a problem hiding this comment.
I think alternatively this can be secrets.GITHUB_TOKEN with issues: write permission, which will appear managed by the github-actions app rather than @nextstrain-bot. We already do something similar for releases (e.g.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Making this usable by other repos.
Related issue(s)
Follow-up to #84
Checklist