-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wnv
to supported pathogen repos
#29
Conversation
Prompted by nextstrain/WNV#13 which includes the addition of a GH Action workflow that uses pathogen-repo-build workflow.
In Slack, @j23414 reported she got this error when attempting to apply this change:
We'll need to adjust how we're defining the role that grew too large. |
While we'll eventually need to split that @j23414 Try again? Also, please merge this branch and push to |
Works, thank you! :D terraform -chdir=env/production apply plan
#> aws_iam_role.GitHubActionsRoleNextstrainBatchJobs: Modifying... [id=GitHubActionsRoleNextstrainBatchJobs]
#> aws_iam_role.GitHubActionsRoleNextstrainBatchJobs: Modifications complete after 1s [id=GitHubActionsRoleNextstrainBatchJobs]
#>
#> Apply complete! Resources: 0 added, 1 changed, 0 destroyed. |
@@ -23,6 +23,7 @@ locals { | |||
"rsv" = ["rsv"], | |||
"seasonal-cov" = ["seasonal-cov"], | |||
"seasonal-flu" = ["seasonal-flu"], | |||
"wnv" = ["wnv"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming back here (after an "ah ha" moment in Slack) to note for posterity that this should have used WNV
, as the actual repo name (e.g. https://github.com/nextstrain/WNV) and pathogen name (e.g. https://nextstrain.org/WNV and https://data.nextstrain.org/WNV_NA.json) are both capitalized. While GitHub's not case-sensitive when it comes to repo names, everything else involved is.
Description of proposed changes
Prompted by nextstrain/WNV#13 which includes
the addition of a GH Action workflow that uses pathogen-repo-build workflow.
Checklist