Add 100k open samples #1075
Merged
Add 100k open samples #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other builds moved to using the zst inputs in ad0d1e3 which was done ~4 days before the 100k profile PR was merged. Note that we are still producing up-to-date .gz files, but the eventual plan is to replace them with zst files.
huddlej
reviewed
Jun 29, 2023
There was a problem hiding this comment.
Thanks for putting this together, @jameshadfield! I left a couple comments about potential typos, but otherwise the code/config all looks good.
File paths chosen to sit nicely alongside our existing intermediate (open) files, such as https://data.nextstrain.org/files/ncov/open/oceania/metadata.tsv.xz https://data.nextstrain.org/files/ncov/open/oceania/sequences.fasta.xz
|
CI passes, as did the two (AWS) jobs triggered by a manual run of the associated GitHub action so I'm going to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
While this PR switches the inputs to zst, the outputs are still xz to maintain consistency (xz file sizes are ~27Mb for sequences+metadata).
Docs updated for 100k, but there's still further updates needed for the other files listed on that page.