Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename template_narrative and fix dataset links [#1135] #1138

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

genehack
Copy link
Contributor

@genehack genehack commented Aug 9, 2024

To comply with file naming convention for narratives and Charon's lack of respect for redirection.

Closes #1135

@joverlee521
Copy link
Contributor

I was checking to see if we can view the narrative on the branch:

https://nextstrain.org/community/narratives/nextstrain/ncov@fix-narrative-1135/template_narrative -> shows a Bad Request

https://nextstrain.org/community/narratives/nextstrain/ncov@fix-narrative-1135/template/narrative -> shows error accessing dataset, but at least it's a different error!

@joverlee521
Copy link
Contributor

shows error accessing dataset, but at least it's a different error!

Ah, the error is related to nextstrain/nextstrain.org#858.
Need to update all of the URLs within narratives/ncov_template_narrative.md

https://nextstrain.org/ncov/global?legend=closed -> https://nextstrain.org/ncov/gisaid/global/6m?legend=closed
https://nextstrain.org/ncov/global?c=country -> https://nextstrain.org/ncov/gisaid/global/6m?c=country
https://nextstrain.org/ncov/global?c=region -> https://nextstrain.org/ncov/gisaid/global/6m?c=region

@genehack genehack changed the title Rename template_narrative [#1135] Rename template_narrative and fix dataset links [#1135] Aug 9, 2024
@genehack
Copy link
Contributor Author

genehack commented Aug 9, 2024

shows error accessing dataset, but at least it's a different error!

Ah, the error is related to nextstrain/nextstrain.org#858.

Thanks now it works!

@genehack genehack merged commit bbb9103 into master Aug 9, 2024
7 checks passed
@genehack genehack deleted the fix-narrative-1135 branch August 9, 2024 18:53
@genehack
Copy link
Contributor Author

genehack commented Aug 9, 2024

@joverlee521
Copy link
Contributor

I've merged this and the branch isn't present any more, what should be the correct link isn't working.

The correct link is now https://nextstrain.org/community/narratives/nextstrain/ncov/template/narrative

I often forget and just go to the main community page to click on the link listed in https://nextstrain.org/community/nextstrain/ncov

@genehack
Copy link
Contributor Author

genehack commented Aug 9, 2024

The correct link is now https://nextstrain.org/community/narratives/nextstrain/ncov/template/narrative

Thanks!

I often forget and just go to the main community page to click on the link listed in https://nextstrain.org/community/nextstrain/ncov

I will say that the mismatch between the URL and the file name strikes me as a potentially vast source of misunderstanding and frustration.

@joverlee521
Copy link
Contributor

I will say that the mismatch between the URL and the file name strikes me as a potentially vast source of misunderstanding and frustration.

The docs explain these technical details, but we definitely still get questions about URLs.

@genehack
Copy link
Contributor Author

I will say that the mismatch between the URL and the file name strikes me as a potentially vast source of misunderstanding and frustration.

The docs explain these technical details, but we definitely still get questions about URLs.

The docs explain the "how?" (and thanks for linking them), but they don't address the "why?" at all, so all I can say is, "having an indirect mapping between the file name on disk and the URL seems potentially frustrating and prone to misunderstanding". 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken template_narritave link
2 participants