Add dataset images #94
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional images to datasets.
The image.png or image.json file can be added to dataset directory along with the `Image` field in `pathogen.json`:
```json
"image": {
"path": "image.png",
"source": "nextstrain.org"
},
```
This allows Nextclade Web to use these images in the UI.
In this PR I copied some of the images from this git version in nextstrain.org:
https://github.com/nextstrain/nextstrain.org/tree/84b5a589b5e819352b52ee6104f1e25fd77bef12/static-site/static/splash_images
ivan-aksamentov
had a problem deploying
to
refs/pull/94/merge
GitHub Actions
Error
ivan-aksamentov
deployed
to
refs/pull/94/merge
GitHub Actions
Active
ivan-aksamentov
deployed
to
refs/pull/94/merge
GitHub Actions
Active
ivan-aksamentov
deployed
to
refs/pull/94/merge
GitHub Actions
Active
ivan-aksamentov
added a commit
to nextstrain/nextclade
that referenced
this pull request
Sep 28, 2023
Display dataset images in lists Sibling PR in data: nextstrain/nextclade_data#94
ivan-aksamentov
force-pushed
the
master
branch
7 times, most recently
from
95a53e0
to
9170a53
Compare
ivan-aksamentov
force-pushed
the
master
branch
7 times, most recently
from
9c290a6
to
0615865
Compare
ivan-aksamentov
force-pushed
the
master
branch
14 times, most recently
from
7fcea3b
to
b59f2dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional images to datasets.
Sibling PR in software: nextstrain/nextclade#1262
The image.png or image.json file can be added to dataset directory along with the
Imagefield inpathogen.json:This allows Nextclade Web to use these images in the UI.
In this PR I copied some of the images from this git version in nextstrain.org:
https://github.com/nextstrain/nextstrain.org/tree/84b5a589b5e819352b52ee6104f1e25fd77bef12/static-site/static/splash_images