Skip to content

Commit

Permalink
Merge pull request #984: Use Heroku-22 stack
Browse files Browse the repository at this point in the history
  • Loading branch information
victorlin authored Aug 14, 2024
2 parents c3b3b03 + e94c218 commit bc3158e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
needs: build
runs-on: ubuntu-latest
container:
image: heroku/heroku:20
image: heroku/heroku:22
env:
# Override NODE_ENV=production default in production build (slug)
NODE_ENV: development
Expand Down
6 changes: 3 additions & 3 deletions scripts/heroku-build
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ docker run \
--volume "$(realpath build/cache)":/build/cache:rw \
--volume "$(realpath build/env)":/build/env:ro \
--env HOME=/tmp \
--env STACK=heroku-20 \
--env STACK=heroku-22 \
--env SOURCE_VERSION \
--env SOURCE_DESCRIPTION \
--env NODE_MODULES_CACHE=false \
heroku/heroku:20-build bash -c '
heroku/heroku:22-build bash -c '
/build/pack/bin/detect /build/app \
&& /build/pack/bin/compile /build/app /build/cache /build/env
'
Expand Down Expand Up @@ -115,7 +115,7 @@ jq \
--argjson procfile "$(<build/app/Procfile.json)" \
--arg checksum "$(awk '{print "SHA256:" $1}' build/slug.tar.gz.sha256sum)" \
'{
"stack": "heroku-20",
"stack": "heroku-22",
"commit": $ENV.SOURCE_VERSION,
"commit_description": $ENV.SOURCE_DESCRIPTION,
"process_types": $procfile,
Expand Down
2 changes: 1 addition & 1 deletion scripts/heroku-exec
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@ docker run \
--env HOME=/app \
--env BASH_ENV=/app/.heroku/BASH_ENV \
"${docker_args[@]:0}" \
heroku/heroku:20 \
heroku/heroku:22 \
bash -c -- 'exec "$@"' "$1" "$@"

0 comments on commit bc3158e

Please sign in to comment.