Port /blog to App router; add blog preview cards [#134]
#1059
+406
−279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-add-blog-p-ky3afp
genehack
force-pushed
the
add-blog-preview-cards-134
branch
from
131c645
to
e3d671d
Compare
nextstrain-bot
temporarily deployed
to
nextstrain-s-add-blog-p-bstxdd
genehack
force-pushed
the
add-blog-preview-cards-134
branch
from
e3d671d
to
94cae8d
Compare
genehack
requested review from
victorlin,
jameshadfield,
tsibley and
joverlee521
genehack
force-pushed
the
add-blog-preview-cards-134
branch
from
94cae8d
to
a960935
Compare
Deletes old Pages Router blog files, as well as displayMarkdown component.
genehack
force-pushed
the
add-blog-preview-cards-134
branch
from
a960935
to
9e5c3bb
Compare
30 tasks
joverlee521
reviewed
Nov 13, 2024
Comment on lines
+12
to
+16
| const redirectTo = mostRecentPost | ||
| ? `/blog/${mostRecentPost.blogUrlName}` | ||
| : `/404`; | ||
|
|
||
| redirect(redirectTo); |
There was a problem hiding this comment.
The images of the most recent blog fail to load when going to /blog, but load fine at /blog/2024-10-22-oropouche-analysis-and-resources
| metadata.openGraph!.url = `/blog/${blogPost.blogUrlName}`; | ||
| } | ||
|
|
||
| return metadata; |
There was a problem hiding this comment.
Hurrah! The original feature that spawned this whole journey into the App router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This ports the
/blogand/blog/[id]pages to App Router. It also adds metadata to blog posts, including OpenGraph tags, to support preview cards. Finally, it updates themarkedMarkdown parser to the current release, in order to get type support, and adds the@types/sanitize-htmldev dependency to provide type support forsanitize-html.Note that this code is on top of, and includes, the changes from #1032; when that is merged, I will rebase this on top of it.This is rebased and ready to review.Related issue(s)
static-sitefrom Pages Router to App Router #1052Checklist