Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for adjusting the layout of the multi-tenant groups bucket #563

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Jun 22, 2022

Ignore objects within each group's prefix starting with "datasets/" or
"narratives/". These sub-prefixes are used in the new layout and during
a brief transition/testing period will have copies of the live data for
any groups already migrated to the multi-tenant bucket. Ignoring them
avoids including them (as non-functional duplicate entries) in the
dataset and narrative listings (e.g. on an individual group's splash
page).

Related issue(s)

Related to #562.

Testing

  • Correctly ignores objects in the new layout for the test-private group, where I've manually adjusted the layout already. Other objects still correctly visible as datasets and narratives in listings.
  • Tests pass locally.

Ignore objects within each group's prefix starting with "datasets/" or
"narratives/".  These sub-prefixes are used in the new layout and during
a brief transition/testing period will have copies of the live data for
any groups already migrated to the multi-tenant bucket.  Ignoring them
avoids including them (as non-functional duplicate entries) in the
dataset and narrative listings (e.g. on an individual group's splash
page).
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-trs-groups-zaxkqq June 22, 2022 19:00 Inactive
@tsibley tsibley requested a review from a team June 22, 2022 19:33
@tsibley
Copy link
Member Author

tsibley commented Jun 22, 2022

I'm going to merge this pre-review, as it should have zero impact on the current behaviour (nothing of import exists under datasets/ or narratives/ currently) and merging will allow better review of #562.

@tsibley tsibley merged commit 3898a59 into master Jun 22, 2022
@tsibley tsibley deleted the trs/groups-storage-layout-preparation branch June 22, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants