Remove legacy groups support #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uckets are migrated
Removes now-unused @aws-sdk/client-{iam,s3} deps. We still use the
previous major version of aws-sdk for S3 access, and that should
eventually upgrade/migrate to using @aws-sdk/client-s3 instead, so I
expect that particular dep will be back sooner than later.
While this removes the last use of run() and setupConsole() in our
src/utils/scripts.js module, I didn't delete them as I think those are
potentially useful enough in the future to keep them around.
There's no need to keep the complexity around, even if it's only somewhat minor.
victorlin
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Testing
test:cipasses locally